feat(subcontracting): Added provision to create multiple Subcontracting Orders against a single Purchase Order #44711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihir-kandoi
force-pushed
the
new_sc_flow_2
branch
from
7f9dbd7 to
da37e29
Compare
…ng Orders from a single Subcontracted Purchase Order
mihir-kandoi
force-pushed
the
new_sc_flow_2
branch
from
75147af to
555dd7c
Compare
rohitwaghchaure
requested review from
ruthra-kumar and
rohitwaghchaure
as code owners
mergify bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
…ng Orders against a single Purchase Order (#44711) * feat(subcontracting): Added provision to create multiple Subcontracting Orders from a single Subcontracted Purchase Order * refactor(new_sc_flow_2): Fixed error thrown by semgrep (cherry picked from commit 3eba6bf) # Conflicts: # erpnext/buying/doctype/purchase_order/purchase_order.js # erpnext/buying/doctype/purchase_order/test_purchase_order.py # erpnext/buying/doctype/purchase_order_item/purchase_order_item.json # erpnext/subcontracting/doctype/subcontracting_order_item/subcontracting_order_item.json # erpnext/subcontracting/doctype/subcontracting_order_service_item/subcontracting_order_service_item.json
mihir-kandoi
added a commit
that referenced
this pull request
Dec 19, 2024
…ng Orders against a single Purchase Order (#44711) * feat(subcontracting): Added provision to create multiple Subcontracting Orders from a single Subcontracted Purchase Order * refactor(new_sc_flow_2): Fixed error thrown by semgrep
rohitwaghchaure
pushed a commit
that referenced
this pull request
Dec 20, 2024
…ng Orders against a single Purchase Order (backport #44711) (#44782) * feat(subcontracting): Added provision to create multiple Subcontracting Orders against a single Purchase Order (#44711) * feat(subcontracting): Added provision to create multiple Subcontracting Orders from a single Subcontracted Purchase Order * refactor(new_sc_flow_2): Fixed error thrown by semgrep (cherry picked from commit 3eba6bf) # Conflicts: # erpnext/buying/doctype/purchase_order/purchase_order.js # erpnext/buying/doctype/purchase_order/test_purchase_order.py # erpnext/buying/doctype/purchase_order_item/purchase_order_item.json # erpnext/subcontracting/doctype/subcontracting_order_item/subcontracting_order_item.json # erpnext/subcontracting/doctype/subcontracting_order_service_item/subcontracting_order_service_item.json * feat(subcontracting): Added provision to create multiple Subcontracting Orders against a single Purchase Order (#44711) * feat(subcontracting): Added provision to create multiple Subcontracting Orders from a single Subcontracted Purchase Order * refactor(new_sc_flow_2): Fixed error thrown by semgrep * fix: Resolved errors and removed code from develop branch merged by mistake --------- Co-authored-by: Mihir Kandoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to fulfil issue #43986
Current flow: Only a single Subcontracting Order could be made against a Subcontracted Purchase Order
New flow: User can now create multiple Subcontracting Orders against a single Purchase Order
How to use: When creating a Subcontracting Order, user now has the ability to change the quantity of finished good item, hence enabling them to create a SO which partly fulfils the corresponding PO
Notes:
https://docs.frappe.io/erpnext/user/manual/en/subcontracting